-
Notifications
You must be signed in to change notification settings - Fork 401
Devinxi - Unified CSS handling #1965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
470bfaf to
99196a1
Compare
commit: |
7a38420 to
3974bd3
Compare
3974bd3 to
e07865f
Compare
|
This is still going to be post-devinxi into main? |
|
bunch of conflicts now too |
7945276 to
c9dd38e
Compare
@brenelz It's still up for discussion of this is going straight into devinxi or if it is going into main. Why 😅? |
@brenelz Just rebased it, conflicts are gone 😃. Next on my TODO list: rework the DEV part (try to render |
5518528 to
27fef42
Compare
c4bd8c2 to
c539295
Compare
❌ Deploy Preview for solid-start-landing-page failed. Why did it fail? →
|
62c43d2 to
978933f
Compare
brenelz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good
8d88d62 to
cb7638b
Compare
7b4838e to
73f49b3
Compare
7eae789 to
206e659
Compare
Design Goals
This PR implements the
Ambient CSS importcolumn of the table below. The?url import + Explicit APIcolumn is part of a separate ongoing progress.Included Fixes
?urlimported asset's are not server rendered anymorebuild.cssCodeSplit: falseoption is used #1324Limitations
lazytranspilation uses a naive approach to narrow down the target files:id$$export to all jsx/tsx files withexport defaulte.g. export { default } from "./xyz.tsxcannot mount the related css, as the aggregated module misses theid$$fromxyz.tsxNew CSS fixture
Tasks
?urlimported css should not be server rendered<link>should be mounted before suspension-end during spa navigationSuspension from spa navigation should only end after- Will be part of a separate API<link>has been loadedPublic manifest andasset mount API (Edit: Public manifest API analog to RFC: Client assets metadata API for SSR vitejs/vite#20913 will be implemented in a different branch)useAssetsin dev (making dev and prod use the same API)lazy